-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Joinmarket GUI #606
base: master
Are you sure you want to change the base?
Add Joinmarket GUI #606
Conversation
}, | ||
{ | ||
"name": "Joinmarket GUI", | ||
"short_name": "jmg" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In case there are issues, I think adding it as a "standalone" app that shows up on the application page may be better for users. Maybe follow a pattern similar to LNDConnect or Pool.
sudo -u joinmarket ./jmg_venv/bin/pip install -r requirements.txt | ||
|
||
# Setup TLS certificates | ||
sudo -u joinmarket mkdir .joinmarket/ssl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There may be a way to re-use an existing cert. I'll need to think about this more.
I had to fix few bugs in my app but now it works on Raspi 4. Few things to address:
|
Also, one of us should update the app installation documentation once this is done. |
Cool, sounds good. I agree with adding the button and additional logic. There are examples for the button + port on main.html and examples for activate / de-active as well. Do you mind taking some notes on what is missing from the install doc? I felt like the basics were covered, but there's likely at least a couple things missing. |
The app button works now, and I have added the logic to show "yellow" status when JM wallet daemon is down. Also, I have made the GUI premium since JoinMarket is premium. What's left to do:
|
Since Dojo is also part of the community edition, I think I'll make JoinMarket part of it as well. I'd like to encourage more people to use it and build on top of it. If it's easier for you, feel free to make that change as part of this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know if I make any mistakes
Web based UI for JoinMarket. It uses
joinmarket-clientserver/scripts/jmwalletd.py
as backendDescription
Checklist
List of test device(s)
Raspi4 64 bit